From 51672dbfc64892250c1514a4258504e99fef8d6a Mon Sep 17 00:00:00 2001
From: Reiner Herrmann <reiner@reiner-h.de>
Date: Sat, 15 Jan 2011 00:08:52 +0100
Subject: use already available msg_type enum..

---
 src/net.c | 8 ++++----
 src/net.h | 5 ++---
 2 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/src/net.c b/src/net.c
index 0eea8a9..0567179 100644
--- a/src/net.c
+++ b/src/net.c
@@ -118,7 +118,7 @@ void client_hello(int sock, const char* username)
 
 	buf = malloc(namelen+2); // type + len + username
 
-	buf[0] = CLIENT_HELLO;
+	buf[0] = msg_type_hello;
 	buf[1] = namelen;
 	memcpy(buf+2, username, namelen);
 
@@ -187,7 +187,7 @@ void server_start_game(int* clients, const uint8_t clientcount, const char* user
 		buflen += strlen(usernames[i]);
 
 	buf = malloc(buflen);
-	buf[pos++] = SERVER_START_GAME;
+	buf[pos++] = msg_type_start_game;
 	buf[pos++] = clientcount;
 	// copy usernames with length to buffer
 	for(int i=0; i<usercount; i++)
@@ -217,7 +217,7 @@ char* server_recv_hello(int sock)
 
 	recv(sock, buf, 13, 0);
 
-	assert(buf[0] == CLIENT_HELLO);
+	assert(buf[0] == msg_type_hello);
 
 	namelen = buf[1];
 	name = malloc(namelen+1);
@@ -247,7 +247,7 @@ void* server_recv(int sock, uint8_t wanted)
 
 	switch(type)
 	{
-		case CLIENT_HELLO:
+		case msg_type_hello:
 			result = server_recv_hello(sock);
 			break;
 	}
diff --git a/src/net.h b/src/net.h
index 6a3d1a5..2fb28c0 100644
--- a/src/net.h
+++ b/src/net.h
@@ -3,13 +3,12 @@
 
 #define MAX_PLAYERS 10
 
-enum packet_type { CLIENT_HELLO, SERVER_START_GAME };
-
 
 typedef enum
 {
 	// Specify message type identifier here
-	msg_type_hello	= 0x0
+	msg_type_hello		= 0x0,
+	msg_type_start_game	= 0x1
 } msg_type_t;
 
 typedef struct
-- 
cgit v1.2.3


From e486953991884606f60d747b0cfb846f576c6bc4 Mon Sep 17 00:00:00 2001
From: Reiner Herrmann <reiner@reiner-h.de>
Date: Sat, 15 Jan 2011 00:15:32 +0100
Subject: added NULL pointer checks

---
 src/net.c | 24 ++++++++++++++++++++++--
 1 file changed, 22 insertions(+), 2 deletions(-)

diff --git a/src/net.c b/src/net.c
index 0567179..1b3811d 100644
--- a/src/net.c
+++ b/src/net.c
@@ -84,7 +84,11 @@ int* server_get_players(int serversock, const uint8_t count)
 	assert(count < MAX_PLAYERS && count > 0);
 
 	clientsocks = malloc(count*sizeof(int));
-	assert(clientsocks != NULL);
+	if(clientsocks == NULL)
+	{
+		printf("server_get_players: Out of memory\n");
+		exit(EXIT_FAILURE);
+	}
 
 	// accept connections
 	for(i=0; i<count; i++)
@@ -117,6 +121,11 @@ void client_hello(int sock, const char* username)
 	uint8_t namelen = strlen(username);
 
 	buf = malloc(namelen+2); // type + len + username
+	if(buf == NULL)
+	{
+		printf("client_hello: Out of memory\n");
+		exit(EXIT_FAILURE);
+	}
 
 	buf[0] = msg_type_hello;
 	buf[1] = namelen;
@@ -187,6 +196,11 @@ void server_start_game(int* clients, const uint8_t clientcount, const char* user
 		buflen += strlen(usernames[i]);
 
 	buf = malloc(buflen);
+	if(buf == NULL)
+	{
+		printf("server_start_game: Out of memory\n");
+		exit(EXIT_FAILURE);
+	}
 	buf[pos++] = msg_type_start_game;
 	buf[pos++] = clientcount;
 	// copy usernames with length to buffer
@@ -221,7 +235,13 @@ char* server_recv_hello(int sock)
 
 	namelen = buf[1];
 	name = malloc(namelen+1);
-	strncpy(name, buf+2, namelen);
+	if(name == NULL)
+	{
+		printf("sender_recv_hello: Out of memory\n");
+		exit(EXIT_FAILURE);
+	}
+
+	memcpy(name, buf+2, namelen);
 	name[namelen] = '\0';
 
 	return name;
-- 
cgit v1.2.3